[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] libsvn_wc (log) #3, result_pool/scratch_pool

From: Martin Hauner <martin.hauner_at_gmx.net>
Date: Sat, 19 Sep 2009 17:14:39 +0200

Hi Greg,

On 19.09.09 14:16, Greg Stein wrote:
> On Sat, Sep 19, 2009 at 06:16, Martin Hauner<martin.hauner_at_gmx.net> wrote:
>> Hi Greg,
>>
>>> I'll be around this weekend, rather than bumming around Hawaii :-) ...
>>> I'll look forward to the patch!
>>
>> here we go... the patch is now against r39457 which is HEAD just NOW.
>>
>> I hope it doesn't have too many issues. It is not really funny to chase HEAD
>> ;-))
>
> Yeah... sorry about that :-(

That's ok, at least I have learned to update more often :)

> I've applied your patch in r39462. Thanks!!

Wow, that was fast :-) Thanks too :)

I'll move on to adm_files.[ch] now if that is ok. Or is there anything more useful?

I have two questions regarding admin_files.[ch]:

- svn_wc_get_adm_dir

Reading the comment I think that it should have both (result/scratch) pools.
Looking at the implementation it just returns a static. Is it worth here
splitting the pool?

- adm_files.[ch]

In most cases there is no comment about the pool usage. Should I add it?

>
> Cheers,
> -g
>

-- 
Martin
Subcommander 2.0.0 Beta 5 - http://subcommander.tigris.org
a Win32/Unix/MacOSX subversion GUI client & diff/merge tool.
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2396877
Received on 2009-09-19 17:14:56 CEST

This is an archived mail posted to the Subversion Dev mailing list.