[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] avoid loggy SEGV

From: Dave Brown <dave.brown_at_wandisco.com>
Date: Thu, 17 Sep 2009 13:49:22 -0700

Stefan Sperling wrote:
> This does not conform to our coding style.
> Should be:
> if (! (*logy_path))
> {
> ...
> }

Properly styled patch attached. Thanks for pointing it out, Stefan.


Raise an error in log.c when given paths that are not in the WC, rather
than letting the code segfault. (Absolute paths in /tmp seem to be
coming from merge operations). Callers of loggy_path() are not prepared
to handle a NULL return anyway. Even though this stuff is going away,
it is crashing midway through the javahl tests. With this change,
the javahl tests complete, getting 1 error and 2 failures.

* subversion/libsvn_wc/log.c
    (loggy_path): return svn_error if path is not a child of
> The fix looks right to me otherwise.
> The docstring says "PATH must not be outside that directory" so
> raising an error if that's the case is perfectly fine.
> Thanks!
> . o O (maybe this variable should be called "loggy_path"?)
> Stefan


Received on 2009-09-17 22:51:06 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.