[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r38295 - in trunk/subversion: include libsvn_wc

From: Hyrum K. Wright <hyrum_at_hyrumwright.org>
Date: Wed, 9 Sep 2009 08:15:49 -0500

On Jul 5, 2009, at 12:57 PM, Greg Stein wrote:

> On Wed, Jul 1, 2009 at 19:21, Hyrum K. Wright<hyrum_at_hyrumwright.org>
> wrote:
>> ...
>> +++ trunk/subversion/include/svn_wc.h Wed Jul 1 10:21:12
>> 2009 (r38295)
>> @@ -4536,12 +4536,27 @@ svn_wc_get_switch_editor(svn_revnum_t *t
>>
>> /** Set @a *props to a hash table mapping <tt>char *</tt> names onto
>> * <tt>svn_string_t *</tt> values for all the regular properties of
>> - * @a path. Allocate the table, names, and values in @a pool. If
>> - * the node has no properties, or does not exist in the working
>> copy,
>> - * then an empty hash is returned. @a adm_access is an access baton
>> - * set that contains @a path.
>> + * @a local_abspath. Allocate the table, names, and values in
>> + * @a result_pool. If the node has no properties, or does not
>> exist in
>> + * the working copy, then an empty hash is returned. Use @a
>> wc_ctx to
>> + * access the working copy, and @a scratch_pool for temporary
>> allocations.
>> + *
>> + * @since New in 1.7.
>> */
>
> Since the API is being rev'd, then let's get this right: if the node
> does not exist, then throw an error.
>
> Callers shouldn't be using this API for missing nodes. They want
> properties, then fine... but the node should be there to fetch
> properties *from*.
>
> This will also allow callers to distinguish between "no props" and
> "does not exist".

r39203.

-Hyrum

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2392862
Received on 2009-09-09 15:16:23 CEST

This is an archived mail posted to the Subversion Dev mailing list.