[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r39201 - trunk/subversion/tests/libsvn_subr

From: Lieven Govaerts <svnlgo_at_mobsol.be>
Date: Wed, 9 Sep 2009 14:21:56 +0200

Bert,

I think you're misinterpreting this testcase.

On Wed, Sep 9, 2009 at 12:41 PM, Bert Huijben<rhuijben_at_sharpsvn.net> wrote:
> Author: rhuijben
> Date: Wed Sep  9 03:41:38 2009
> New Revision: 39201
>
> Log:
> * subversion/tests/libsvn_subr/dirent_uri-test.c
>  (test_uri_is_child): Switch a few windows dirent cases that should use
>    svn_dirent_is_child to uris with schema to extend test coverage.

These aren't 'windows dirent testcases', these are tests for paths in
the repository.

I've specifically added these cases to test the scenario where people
on unix can add /H:test/trunk in their repository. Windows people
won't be able to checkout this path, but should be able to manipulate
them directly in the repository.

Lieven

>
> Modified:
>   trunk/subversion/tests/libsvn_subr/dirent_uri-test.c
>
> Modified: trunk/subversion/tests/libsvn_subr/dirent_uri-test.c
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/tests/libsvn_subr/dirent_uri-test.c?pathrev=39201&r1=39200&r2=39201
> ==============================================================================
> --- trunk/subversion/tests/libsvn_subr/dirent_uri-test.c        Wed Sep  9 03:13:29 2009        (r39200)
> +++ trunk/subversion/tests/libsvn_subr/dirent_uri-test.c        Wed Sep  9 03:41:38 2009        (r39201)
> @@ -1563,11 +1563,11 @@ test_uri_is_child(apr_pool_t *pool)
>     ".foo",
>     "/",
>     "foo2",
> -    "H:/foo/bar",
> -    "H:/foo/baz",
> +    "http://foo/bar",
> +    "http://foo/baz",
>     "H:",
> -    "H:foo",
> -    "H:foo/baz",
> +    "http://foo",
> +    "http://f",
>     };
>
>   static const char * const
> @@ -1585,7 +1585,7 @@ test_uri_is_child(apr_pool_t *pool)
>     { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
>       0, 0, 0, 0, 0 },
>     { 0, 0, 0, 0, 0, 0, 0, "foo", ".foo", 0, "foo2",
> -      "H:/foo/bar", "H:/foo/baz", "H:", "H:foo", "H:foo/baz" },
> +      0, 0, "H:", 0, 0 },
>     { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
>       0, 0, 0, 0, 0 },
>     { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
> @@ -1595,16 +1595,14 @@ test_uri_is_child(apr_pool_t *pool)
>       0, 0, 0, 0, 0 },
>     { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
>       0, 0, 0, 0, 0 },
> -    /* H:/ paths */
>     { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
>       0, 0, 0, 0, 0 },
>     { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
>       0, 0, 0, 0, 0 },
> -    /* H: paths */
>     { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
> -      "foo/bar", "foo/baz", 0, 0, 0 },
> +      0, 0, 0, 0, 0 },
>     { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
> -      0, 0, 0, 0, "baz" },
> +      "bar", "baz", 0, 0, 0 },
>     { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
>       0, 0, 0, 0, 0 },
>   };
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=495&dsMessageId=2392827
>

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2392852
Received on 2009-09-09 14:22:42 CEST

This is an archived mail posted to the Subversion Dev mailing list.