[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fixed issue 3436 : Short option for --ignore-externals (-i?)

From: Edmund Wong <ed_at_kdtc.net>
Date: Tue, 01 Sep 2009 16:05:42 +0800

Daniel Shahaf wrote:
>> {'r', 'N', opt_depth, opt_set_depth, 'q', opt_merge_cmd, opt_force,
>> - opt_ignore_externals, opt_changelist, opt_editor_cmd, opt_accept} },
>> + opt_ignore_externals, opt_ignore_externals_short, opt_changelist,
>> + opt_editor_cmd, opt_accept} },
>
> Notice there is no opt_changelist_short item corresponding to the "--cl"
> option. Your implementation causes hard-to-maintain code (we have to
> remember to have add opt_ignore_externals_short wherever we add
> opt_ignore_externals). To address this, could you instead implement
> "--ie" in the same way "--cl" is implemented?
>

Thanks Daniel. Redoing the patch right now and am testing it.

Edmund

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2389689
Received on 2009-09-01 10:12:10 CEST

This is an archived mail posted to the Subversion Dev mailing list.