[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fixed issue 3436 : Short option for --ignore-externals (-i?)

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Tue, 1 Sep 2009 09:13:15 +0300 (Jerusalem Daylight Time)

Edmund Wong wrote on Tue, 1 Sep 2009 at 10:31 +0800:
> Fix issue #3436: Short option for --ignore-externals (-i?).
>
> Instead of using the suggested -i, markphip suggested --ie
> which is what is implemented following the discussion
> at
> http://subversion.tigris.org/ds/viewMessage.do?dsMessageId=2370618&dsForumId=462.
>
> * subversion/svn/main.c
> (svn_cl__longopt_t): Added a new item opt_ignore_externals_short.

...

> {'r', 'N', opt_depth, opt_set_depth, 'q', opt_merge_cmd, opt_force,
> - opt_ignore_externals, opt_changelist, opt_editor_cmd, opt_accept} },
> + opt_ignore_externals, opt_ignore_externals_short, opt_changelist,
> + opt_editor_cmd, opt_accept} },

Notice there is no opt_changelist_short item corresponding to the "--cl"
option. Your implementation causes hard-to-maintain code (we have to
remember to have add opt_ignore_externals_short wherever we add
opt_ignore_externals). To address this, could you instead implement
"--ie" in the same way "--cl" is implemented?

Thanks,

Daniel

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2389658
Received on 2009-09-01 08:13:40 CEST

This is an archived mail posted to the Subversion Dev mailing list.