[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Renaming svn_eol_* functions to svn_eol__*.

From: Hyrum K. Wright <hyrum_at_hyrumwright.org>
Date: Mon, 31 Aug 2009 05:55:55 -0500

On Aug 31, 2009, at 5:18 AM, Stefan Sperling wrote:

> On Sat, Aug 29, 2009 at 12:39:07PM +0800, Edmund Wong wrote:
>> Since the svn_eol_* functions are in the private
>> headers, Arfrever pointed out that they should be
>> renamed to s/svn_eol_/&_/g.
>
> Some small remarks on the log message:
>
>> Log:
>>
>> [[[
>
> You might want to put a short note describing the overall change
> here, unless the change is really trivial. In this case, we could
> say:
>
> "Follow-up to r38983: The new eol functions are supposed to be
> private,
> not public, so rename them accordingly."
>>
>> * subversion/libsvn_subr/eol.c,
>> subversion/libsvn_diff/diff_file.c,
>
> The asterisk alone is a good enough visual hint for the grouping.
> So the indentation isn't needed, and these can all go on the same
> line, like this:
>
> * subversion/libsvn_subr/eol.c,
> subversion/libsvn_diff/diff_file.c,

Not to be pedantic (well, actually, I am being pedantic), but the
examples in HACKING include the indentation for each file in a
condensed file list. See http://subversion.tigris.org/hacking.html#log-messages

-Hyrum

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2388838
Received on 2009-08-31 12:56:15 CEST

This is an archived mail posted to the Subversion Dev mailing list.