[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Renaming svn_eol_* functions to svn_eol__*.

From: Stefan Sperling <stsp_at_elego.de>
Date: Mon, 31 Aug 2009 11:18:45 +0100

On Sat, Aug 29, 2009 at 12:39:07PM +0800, Edmund Wong wrote:
> Since the svn_eol_* functions are in the private
> headers, Arfrever pointed out that they should be
> renamed to s/svn_eol_/&_/g.

Some small remarks on the log message:

> Log:
>
> [[[

You might want to put a short note describing the overall change
here, unless the change is really trivial. In this case, we could
say:

"Follow-up to r38983: The new eol functions are supposed to be private,
not public, so rename them accordingly."
>
> * subversion/libsvn_subr/eol.c,
> subversion/libsvn_diff/diff_file.c,

The asterisk alone is a good enough visual hint for the grouping.
So the indentation isn't needed, and these can all go on the same
line, like this:

* subversion/libsvn_subr/eol.c,
  subversion/libsvn_diff/diff_file.c,

> subversion/tests/libsvn_subr/eol-test.c,
> subversion/libsvn_client/patch.c,
> subversion/include/private/svn_eol_private.h:

The colon above is not necessary. I usually put the colon just between
listing all the affected files/items and describing the change.
This aligns with the examples in HACKING.

> (svn_eol_find_eol_start, svn_eol_detect_eol,
> svn_eol_detect_file_eol): Renamed from ...

I.e. the colon here is fine.

I've also compacted the entries a little so that each item is
only listed once, like this:

* subversion/libsvn_subr/eol.c,
  subversion/include/private/svn_eol_private.h
  (svn_eol_find_eol_start, svn_eol_detect_eol,
   svn_eol_detect_file_eol): Renamed from these ...
  (svn_eol__find_eol_start, svn_eol__detect_eol,
   svn_eol__detect_file_eol): ... to these.

* subversion/libsvn_diff/diff_file.c,
  subversion/tests/libsvn_subr/eol-test.c,
  subversion/libsvn_client/patch.c: Track renames.

Committed in r38990.

Thanks,
Stefan

> * subversion/libsvn_subr/eol.c,
> subversion/libsvn_diff/diff_file.c,
> subversion/tests/libsvn_subr/eol-test.c,
> subversion/libsvn_client/patch.c,
> subversion/include/private/svn_eol_private.h:
> (svn_eol__find_eol_start, svn_eol__detect_eol,
> svn_eol__detect_file_eol): ... to.
>
> Patch by: Edmund Wong ed <at> kdtc.net
> Suggested by: arfrever
>
> ]]]

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2388820
Received on 2009-08-31 12:19:20 CEST

This is an archived mail posted to the Subversion Dev mailing list.