Re: [PATCH] Consolidate EOL functions to new libsvn_subr/eol.c

I'm posting with my other account because I didn't get this nor
any other posts. *sigh*

On Tue, 18 Aug 2009 09:35:19 +0100, Stefan Sperling wrote
> On Tue, Aug 18, 2009 at 09:57:39AM +0800, Edmund Wong wrote:
> > Index: subversion/libsvn_subr/eol.c
> > ==================================================================> ---
subversion/libsvn_subr/eol.c (revision 0)
> > +++ subversion/libsvn_subr/eol.c (revision 0)
> > @@ -0,0 +1,140 @@
> > +/*
> > + * eol.c : generic eol/keyword routines
>
> > +
> > +#define APR_WANT_STRFUNC
> > +#include <apr_want.h>
> > +
> > +#include <stdlib.h>
> > +#include <assert.h>
> > +#include <apr_pools.h>
> > +#include <apr_tables.h>
> > +#include <apr_file_io.h>
> > +#include <apr_strings.h>
> > +
> > +#include "svn_cmdline.h"
> > +#include "svn_types.h"
> > +#include "svn_string.h"
> > +#include "svn_time.h"
> > +#include "svn_dirent_uri.h"
> > +#include "svn_path.h"
> > +#include "svn_error.h"
> > +#include "svn_utf.h"
> > +#include "svn_io.h"
> > +#include "svn_subst.h"
> > +#include "svn_pools.h"
> > +
> > +#include "svn_private_config.h"
> > +#include "private/svn_eol_private.h"
>
> subr/eol.c should not need all these #includes.
> Can you try to trim down the number of headers to what's necessary?

I'll do that. I should think before I copy and pasted it.

>
> > Index: subversion/tests/libsvn_subr/subst-test.c
> > ==================================================================> ---
subversion/tests/libsvn_subr/subst-test.c (revision 38767)
> > +++ subversion/tests/libsvn_subr/subst-test.c (working copy)
> > @@ -28,6 +28,7 @@
> > #include "svn_subst.h"
> >
> > #include "../svn_test.h"
> > +#include "private/svn_eol_private.h"
> > 
> >
>
> Weren't there any function calls which needed to be renamed
> in this file?
>

Yes, there should be. I'll take a gander at it.

Thanks.

Ed

--
"Pax tecum"
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2384687