[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Consolidate EOL functions to new libsvn_subr/eol.c

From: Stefan Sperling <stsp_at_elego.de>
Date: Tue, 18 Aug 2009 09:35:19 +0100

On Tue, Aug 18, 2009 at 09:57:39AM +0800, Edmund Wong wrote:
> Index: subversion/libsvn_subr/eol.c
> ==================================================================> --- subversion/libsvn_subr/eol.c (revision 0)
> +++ subversion/libsvn_subr/eol.c (revision 0)
> @@ -0,0 +1,140 @@
> +/*
> + * eol.c : generic eol/keyword routines

> +
> +#define APR_WANT_STRFUNC
> +#include <apr_want.h>
> +
> +#include <stdlib.h>
> +#include <assert.h>
> +#include <apr_pools.h>
> +#include <apr_tables.h>
> +#include <apr_file_io.h>
> +#include <apr_strings.h>
> +
> +#include "svn_cmdline.h"
> +#include "svn_types.h"
> +#include "svn_string.h"
> +#include "svn_time.h"
> +#include "svn_dirent_uri.h"
> +#include "svn_path.h"
> +#include "svn_error.h"
> +#include "svn_utf.h"
> +#include "svn_io.h"
> +#include "svn_subst.h"
> +#include "svn_pools.h"
> +
> +#include "svn_private_config.h"
> +#include "private/svn_eol_private.h"

subr/eol.c should not need all these #includes.
Can you try to trim down the number of headers to what's necessary?

> Index: subversion/tests/libsvn_subr/subst-test.c
> ==================================================================> --- subversion/tests/libsvn_subr/subst-test.c (revision 38767)
> +++ subversion/tests/libsvn_subr/subst-test.c (working copy)
> @@ -28,6 +28,7 @@
> #include "svn_subst.h"
>
> #include "../svn_test.h"
> +#include "private/svn_eol_private.h"
>
>

Weren't there any function calls which needed to be renamed
in this file?

Stefan

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2384658
Received on 2009-08-18 10:35:56 CEST

This is an archived mail posted to the Subversion Dev mailing list.