[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r38507 - trunk/subversion/libsvn_wc

From: Greg Stein <gstein_at_gmail.com>
Date: Sun, 9 Aug 2009 17:27:25 +0200

On Fri, Jul 31, 2009 at 05:50, Hyrum K. Wright<hyrum_at_hyrumwright.org> wrote:
>...
> +++ trunk/subversion/libsvn_wc/wc_db.c  Thu Jul 30 20:50:57 2009        (r38507)
>...
> @@ -2932,6 +2937,103 @@ svn_wc__db_op_mark_resolved(svn_wc__db_t
>  }
>
>
> +struct remove_tc_baton
> +{
> +  const char *local_abspath;
> +  apr_int64_t wc_id;
> +  const char *local_relpath;
> +  const char *parent_abspath;
> +
> +  apr_pool_t *scratch_pool;
> +};

Why local_abspath? You only use the basename of that.

I'd suggest a split() call in the caller to set parent/base.

>...

Cheers,
-g

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2381846
Received on 2009-08-09 17:27:58 CEST

This is an archived mail posted to the Subversion Dev mailing list.