[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r38450 - in trunk/subversion: include/private libsvn_client libsvn_wc

From: Greg Stein <gstein_at_gmail.com>
Date: Sun, 9 Aug 2009 16:38:03 +0200

On Mon, Jul 20, 2009 at 20:03, Hyrum K. Wright<hyrum_at_hyrumwright.org> wrote:
> Author: hwright
> Date: Mon Jul 20 11:03:36 2009
> New Revision: 38450
>
> Log:
> Rev another libsvn_wc private-public API.
>
> (As an aside, having these APIs feels a bit like cheating.  I mean, if we use
> them, and they are useful, shouldn't we expose them to the rest of the world?
> Not only do we let others use these APIs, but we also get rid of this
> "svn_wc__blah() is not really internal, so we need an *additional* wrapper
> around it to pull out the wc_db param" dance.  Oh well, maybe in some future
> life...)

Well... the "idea" is that we're not sure that the APIs are baked
enough and ready to stand behind.

Not sure I totally agree, especially given the number of uses of some
of those APIs, but that was the thinking. Personally, I'd try and get
rid of them, or move some to the public APIs.

Cheers,
-g

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2381840
Received on 2009-08-09 16:38:23 CEST

This is an archived mail posted to the Subversion Dev mailing list.