[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

trunk and 1.6.x leaking errors

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Wed, 05 Aug 2009 10:40:59 -0400

I noticed today that my 1.6.x client (built from the tip-o-the-branch) was
leaking errors. (The tell-tale "Aborted" message at the end of an operation
was a dead giveaway.) I tracked the leak to the function
subversion/libsvn_client/commit_util.c:bail_on_tree_conflicted_ancestor(),
which totally drops errors from both svn_wc__strictly_is_wc_root() and
svn_wc_conflicted_p2(). (In this case, it was the former function that was
returning the leaked error.) And I confirmed that the trunk code has the
same problems.

The naive fix, however (just wrapping these calls in SVN_ERR()) makes me
think that doing this correctly requires more than mere naivety. A simple
commit with said fix results in:

   subversion/libsvn_wc/update_editor.c:5147: (apr_err=150004)
   svn: '/home/cmpilato/tests' has no ancestry information

Does this mean anything to anyone? Is it an acceptable error to ignore?
The recipe is easy enough:

   $ svnadmin create repos
   $ svn co file://`pwd`/repos wc
   Checked out revision 0.
   $ touch wc/file
   $ svn add wc/file
   A wc/file
   $ svn ci -m "" wc
   subversion/libsvn_wc/update_editor.c:5147: (apr_err=150004)
   svn: '/home/cmpilato/tests' has no ancestry information
   $

Thoughts?

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2380483

Received on 2009-08-05 16:41:34 CEST

This is an archived mail posted to the Subversion Dev mailing list.