Re: Mismatched backwards compat callbacks in libsvn_wc

Hyrum K. Wright <hyrum_at_hyrumwright.org> писал в своём письме Thu, 02 Jul
2009 19:44:44 +0400:

> I applied the patch locally, and the python tests no longer segfault.
> Thanks very much for tracking this down! With the patch, I now get an
> error in the tests, but not a crash:

> ======================================================================
> ERROR: test_lock (wc.SubversionWorkingCopyTestCase)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/home/hwright/dev/svn-trunk/subversion/bindings/swig/python/
> tests/wc.py", line 48, in test_lock
> lock = wc.add_lock(self.path, core.svn_lock_create(core.Pool()),
> self.wc)
> File "/home/hwright/dev/svn-trunk/subversion/bindings/swig/python/
> libsvn/wc.py", line 2814, in svn_wc_add_lock
> return apply(_wc.svn_wc_add_lock, args)
> SubversionException: ('traced call', 200030)
>
> ----------------------------------------------------------------------

This is a different test, but yep, happens for me too. Will investigate.

> (Note that that this doesn't *not* solve the segfault in the ruby
> tests.)

That's outside my expertise, unfortunately.

> Any improvements to documentation, including function naming are
> definitely encouraged. Feel free to do a followup patch.

Alrighty then!

[[[
Give the svn_wc_diff_callbacks*_t wrappers more descriptive names.

* subversion/libsvn_wc/deprecated.c: rename callbacks*_wrapper_baton to
diff_callbacks*_wrapper_baton, callbacks*_wrapper to
diff_callbacks*_wrapper and the wrapper functions to wrap_?to*_<basename>.
]]]

Roman.

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2367601