[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Mismatched backwards compat callbacks in libsvn_wc

From: Роман Донченко <DXDragon_at_yandex.ru>
Date: Thu, 02 Jul 2009 03:26:20 +0400

Роман Донченко <DXDragon_at_yandex.ru> писал в своём письме Sat, 27 Jun 2009
20:27:25 +0400:

> The immediate fix is obviously to write new wrappers for (3) and put them
> in callbacks3_wrapper.

The immediate fix is attached. It's rather trivial. 8=] Also of note is
that it fixes the Python test I was struggling with.

Create proper wrapper functions for svn_wc_diff_callbacks3_t and use them.
Also change the misleading comments on the old wrappers.

* subversion/libsvn_wc/deprecated.c
   (file_changed, file_deleted, dir_deleted, dir_props_changed, dir_opened,
dir_closed): Relabel as svn_wc_diff_callbacks3_t functions, since that's
what they're used as.
   (file_changed3, file_deleted3, dir_deleted3, dir_props_changed3,
dir_opened2, dir_closed2): New functions.
   (callbacks3_wrapper): Use the new functions above.

> B. The naming scheme for wrappers is, well, poor. First, the names don't
> contain an indication of "wrapperness", so the purpose isn't immediately
> obvious; plus one may confuse, say, (1)::file_changed with
> ::file_changed.
> Second, the names don't convey which generation of callbacks are they
> wrapping to and from. Combined with A, this makes the names quite
> unhelpful.

I'd also post a patch renaming the wrappers to something more telling — if
someone approves.

> That's all for now.
> Generally yours,
> Roman.

What he said.


Received on 2009-07-02 01:28:38 CEST

This is an archived mail posted to the Subversion Dev mailing list.