[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: New svn:keywords behavior in 1.6 is breaking Eclipse refactoring

From: Bert Huijben <rhuijben_at_sharpsvn.net>
Date: Wed, 1 Jul 2009 10:10:25 +0200

> -----Original Message-----
> From: Mark Phippard [mailto:markphip_at_gmail.com]
> Sent: maandag 29 juni 2009 22:14
> To: dev_at_subversion.tigris.org
> Subject: Re: New svn:keywords behavior in 1.6 is breaking Eclipse
> refactoring
>
> Does anyone have any comments on this? I cannot see any specific
> post-1.5 changes to the code to explicitly make this behavior change.
> I think this must have come about as part of the work gstein did
> pre-1.6 to use streams more and improve some of the codebase. This
> must have come about as a side effect of running the code through a
> different path. At least that is the best I can think of.
>
> I do not think the current code is correct and we ought to revert to
> the previous behavior of updating the keywords on commit.

*Only* on commit?

I assume we still do the updating on commit, but now also on copying/moving? (Otherwise we have a pretty major issue here)

Most likely we also normalize newlines then.

(Mark: AnkhSVN is immune for this class of issues, as me move the real file away when performing the subversion commands, and we move it back after the subversion command completed. And we make sure the rest of VS is unaware of the file changing at that time).

        Bert

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2366958
Received on 2009-07-01 10:12:08 CEST

This is an archived mail posted to the Subversion Dev mailing list.