On 24/06/2009, at 10.58, Jon Bendtsen wrote:
> On 24/06/2009, at 10.04, Florian Weimer wrote:
>
>> * Jon Bendtsen:
>>
>>> Why not apply all of them? And then let the users decide which they
>>> want to use?
>>
>> Too many alternatives left to the user often reflect lack of
>> leadership from the developers. 8-)
>
> But are there too many alternatives?
>
>
>> Anyway, what is needed to get (some of) these patches applied?
>
> Probably some more testing? And someone with write access.
Here is a patch that combines all 3 max size limits into one patch.
There is a little trouble getting them all together because all 3
extends the same functions.
I have decided against making Florians suggestion of adding a text like:
[21 added lines, 18 deleted lines in 3 hunks omitted]
because it will take computational resources to calculate and i do not
think there is value in knowing how many lines are changed.
[[[
Issue 2213: mailer.py should allow limiting of size of emails sent
mailer.py: made code changes that allows some limiting the size of
emails by counting the number of file diffs, or the line count of a
diff or the entire email.
mailer.conf.example: Described how to use the above changes.
]]]
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2366299
On 24/06/2009, at 10.58, Jon Bendtsen wrote:
> On 24/06/2009, at 10.04, Florian Weimer wrote:
>
>> * Jon Bendtsen:
>>
>>> Why not apply all of them? And then let the users decide which they
>>> want to use?
>>
>> Too many alternatives left to the user often reflect lack of
>> leadership from the developers. 8-)
>
> But are there too many alternatives?
>
>
>> Anyway, what is needed to get (some of) these patches applied?
>
> Probably some more testing? And someone with write access.
Here is a patch that combines all 3 max size limits into one patch.
There is a little trouble getting them all together because all 3
extends the same functions.
I have decided against making Florians suggestion of adding a text like:
[21 added lines, 18 deleted lines in 3 hunks omitted]
because it will take computational resources to calculate and i do not
think there is value in knowing how many lines are changed.
[[[
Issue 2213: mailer.py should allow limiting of size of emails sent
mailer.py: made code changes that allows some limiting the size of
emails by counting the number of file diffs, or the line count of a
diff or the entire email.
mailer.conf.example: Described how to use the above changes.
]]]
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2366299
Received on 2009-06-29 13:11:45 CEST