[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Trimming mailer.py messages (issue 2213)

From: Jon Bendtsen <jbendtsen_at_laerdal.dk>
Date: Mon, 22 Jun 2009 11:07:24 +0200

On 22/06/2009, at 09.53, Florian Weimer wrote:

> Why haven't those patches been applied yet? I think I can guess the
> reason: To me, it's still unclear what type of limit is best. A
> per-diff limit doesn't actually bound the message size, so it's
> problematic. If set too low, it also affects single-file changes, and
> if set too high, it doesn't bring down the size of large merges.
> Truncating the whole message instead is somewhat rude, and makes sense
> only as a safety net to protect your mail infrastructure.

I made those patches the way i did because my developers complained
about message size, diffs they didnt understand ("binary"), and didnt
read because it was too large. The large ones they would rather read
in ViewVC or their IDE, so they could get coloring and such.

Based on all that i made patches that could limit each diff size, the
number of diffs, the maximum email size and a patch that forces some
files to be considered binary even if they look like text.


Received on 2009-06-22 11:11:57 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.