[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Error leak leads to confusing place

From: Greg Stein <gstein_at_gmail.com>
Date: Wed, 27 May 2009 01:46:39 +0200

Thanks for tracking this issue!

Contrary to popular opinion, I'm not (yet) honeymooning. That is first
week of July. But I *am* a very happy, newly-married man. As of
Saturday, about 11:30am! :-)

Currently in SF, as a short escape from Vegas. Not really catching up,
but I saw that I was cc'd here....

I believe the right answer for 1.6 and trunk is an SVN_ERR() in both
cases (as cmpilato posited). I don't think we should be dropping that
error on the floor.

Cheers,
-g

On Tue, May 26, 2009 at 22:49, C. Michael Pilato <cmpilato_at_collab.net> wrote:
> Hyrum K. Wright wrote:
>>> What should be done for 1.6.x in terms of fixing this?
>>
>> The fix seems pretty apparent for 1.6.x.  I'd just create a backport
>> branch, apply the fix to the branch, and then nominate rev X from the
>> branch for backport.
>
> You've explained the method of getting a fix into 1.6.x (which I appreciate
> ... thanks).  The fix itself should be consistent with trunk's approach.  I
> happen to think that trunk's current approach is wrong, that the
> "svn_error_clear(err);" should instead be "SVN_ERR(err);", and that *that*
> is what is backported to 1.6.x.  I'll await Greg's opinion on that, though.
>
> --
> C. Michael Pilato <cmpilato_at_collab.net>
> CollabNet   <>   www.collab.net   <>   Distributed Development On Demand
>
>

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2354685
Received on 2009-05-27 01:47:00 CEST

This is an archived mail posted to the Subversion Dev mailing list.