[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Error leak leads to confusing place

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Tue, 26 May 2009 16:49:49 -0400

Hyrum K. Wright wrote:
>> What should be done for 1.6.x in terms of fixing this?
>
> The fix seems pretty apparent for 1.6.x. I'd just create a backport
> branch, apply the fix to the branch, and then nominate rev X from the
> branch for backport.

You've explained the method of getting a fix into 1.6.x (which I appreciate
... thanks). The fix itself should be consistent with trunk's approach. I
happen to think that trunk's current approach is wrong, that the
"svn_error_clear(err);" should instead be "SVN_ERR(err);", and that *that*
is what is backported to 1.6.x. I'll await Greg's opinion on that, though.

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2354294

Received on 2009-05-26 22:50:10 CEST

This is an archived mail posted to the Subversion Dev mailing list.