Hi Mark, Stefan, Brane
On Fri, May 22, 2009 at 6:55 AM, Mark Phippard <markphip_at_gmail.com> wrote:
> On Fri, May 22, 2009 at 9:52 AM, Stefan Sperling <stsp_at_elego.de> wrote:
>> On Thu, May 21, 2009 at 11:26:50PM -0700, Joe Swatosh wrote:
>>> Make the Ruby and Perl shared libraries .dll instead of .pyd. There is
>>> probably a smarter way to do this with the ._extension_map, but I'm no
>>> kind of Python expert.
>> Your log message and explanation of your patch do not contain any
>> reasoning about why r37331 needs to be reverted. Can you explain?
>> You seem to assume that everyone already knows what's wrong with
>> .pyd. But, for example, I don't even know what a .pyd is! :)
>> Please try to explain the reasoning behind a change in the log message.
> I had the same reaction. I suspect that it is tied to the comment
> about Ruby. Clearly, the Ruby bindings DLL should not be named .pyd
> as that is a Python-specific extension. So perhaps the problem is
> that the way this change was implemented it impacts the Ruby bindings?
Hm. I guess I was having a hard time yesterday saying what I mean. Maybe
it was just too late. That is it exactly. r37331 changed the extensions of the
shared libraries for all the SWIG based bindings to .pyd. Truthfully, I don't
know what a .pyd is either, but it prevented the Ruby (and I am assuming)
the Perl bindings from working.
Partially revert r37331 "On Windows, shared libs for Python bindings
should be *.pyd not *.dll."
It appears renaming the shared libraries for Perl and Ruby was
inadvertent, so change the extension back to .dll for Ruby and Perl.
* build/generator/gen_base.py (TargetSWIG.add_dependencies): Mark Python
wrapper shared libs as type "pyd" not "lib".
Received on 2009-05-22 17:02:30 CEST