[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] fix for issue 3404 (svnsync 1.6 fails on ^M)

From: Neels Janosch Hofmeyr <neels_at_elego.de>
Date: Wed, 20 May 2009 01:27:01 +0200

Hi Ben,

are you still there? I'm reviewing your patch and am having some questions...

[[[
+/** When present in r0, svnsync should perform eol normalization of
+ svn: properties for sync and copy-revprops subcommands. */
+#define SVNSYNC_PROP_FIX_SVN_PROP_EOL_STYLE \
+ SVNSYNC_PROP_PREFIX "fix-svn-prop-eol-style"
]]]

Could you reason some more why you do this please?

Firstly, isn't line ending normalization always desired? (well maybe not,
maybe some people rather want to be warned about it, to be able to decide
whether they go on or opt out entirely.)

Ok, so I do `svn propset svn:fix-svn-prop-eol-style -revprop -r0 true`, and
then all of the svn: props are normalized during sync. Is that right?

If yes, it would probably be better placed in the repository config file,
instead of a revision prop...

But then again, do we *really* need this to be configurable per repository?
Isn't a commandline option to svnsync sufficient? The API specs require the
props to be consistent, so it's useless when they aren't.

I'd be grateful if you could clarify :)
(note: I don't know zip about svnsync)

Thanks,
~Neels

P.S.: it's best to produce a patch for this list using `svn diff` in your
working copy root. as in...
 svn co $svnrepos/trunk
 < madly edit inside trunk/ >
 cd trunk # go to the root of the subversion source tree
 svn diff > my_suggestion.patch

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2321580

Received on 2009-05-20 01:27:22 CEST

This is an archived mail posted to the Subversion Dev mailing list.