[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r37709 - trunk/subversion/libsvn_subr

From: Greg Stein <gstein_at_gmail.com>
Date: Tue, 12 May 2009 18:18:49 +0200

On Tue, May 12, 2009 at 18:12, Arfrever Frehtes Taifersar Arahesis
<Arfrever.FTA_at_gmail.com> wrote:
> 2009-05-12 17:42:01 Bert Huijben napisał(a):
>> > -----Original Message-----
>> > From: Arfrever Frehtes Taifersar Arahesis [mailto:Arfrever.FTA_at_GMail.Com]
>> > Sent: dinsdag 12 mei 2009 17:31
>> > To: svn_at_subversion.tigris.org
>> > Subject: svn commit: r37709 - trunk/subversion/libsvn_subr
>> >
>> > Author: arfrever
>> > Date: Tue May 12 08:30:42 2009
>> > New Revision: 37709
>> >
>> > Log:
>> > When SVN_DEBUG is defined, print error messages containing details about
>> > failures of dynamic loading of libraries performed by apr_dso_load().
>> >
>> > * subversion/libsvn_subr/dso.c
>> >   (svn_dso_load): Print message retrieved by apr_dso_error().
>>
>> Why is this necessary?
>>
>> If the error is useful, the full error message can be returned (as wrapped
>> error?) in the svn_error_t* returned by this function
>
> The doc string of svn_dso_load() contains:
> "If @a libname cannot be loaded set @a dso to NULL and return @c SVN_NO_ERROR."
>
> The error message might be useful to find bugs such as the one introduced
> in r35309+r35385+r36823.

How about rev'ing the API and returning a proper error?

(and the old API can continue to suck at error reporting... we don't
care since we'll update our calls)

Cheers,
-g

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2216746
Received on 2009-05-12 18:19:08 CEST

This is an archived mail posted to the Subversion Dev mailing list.