I am not OK with it. We (including you) spent several months last
year getting this to work properly on RHEL 4/5 and I would be strongly
against not supporting the feature properly on those operating
systems.
Mark
On Mon, Apr 27, 2009 at 5:41 AM, Senthil Kumaran S <senthil_at_collab.net> wrote:
> Arfrever Frehtes Taifersar Arahesis wrote:
>>> 2b) It should probably be called "Subversion passwords" instead of "network
>>> password".
>>
>> It might be caused by using of gnome_keyring_find_network_password_sync()
>> and gnome_keyring_set_network_password_sync().
>
> Ok all these difficulties pop up because we try to support older versions of
> gnome-keyring (I really don't know the exact version which qualifies for
> "older", may be what RHEL5 supports?), if we plan to support gnome-keyring
> version 2.22 and above then we can implement things in a smarter way which I ve
> attempted in the patch attached (not yet ready to commit, because we can remove
> more code in 'subversion/libsvn_auth_gnome_keyring/gnome_keyring.c', by
> supporting keyring >2.22).
>
> If everyone is ok with depending on gnome-keyring 2.22 and above, then I can
> come up with more pleasing implementation. There is no trade off here because
> most of the distros like Debian/Ubuntu/Fedora/Gentoo? etc already have latest
> gnome-keyring libraries except for CentOS/RHEL.
>
> One more interesting thing in moving to 2.22 or greater is that we can store
> more info in the keyring as we do in ./subversion/auth/svn.simple, which is
> possible with older versions too, but that is a maintainance headache.
>
> A simple structure provided by latest keyring is this,
>
> <snip>
> GNOME_KEYRING_NETWORK_PASSWORD;
>
> * user: A string for the user login.
> * server: The server being connected to.
> * protocol: The protocol used to access the server, such as 'http' or 'smb'
> * domain: A realm or domain, such as a Windows login domain.
> * port: The network port to used to connect to the server.
> </snip>
>
> We can customize the above/come up with our own structure too. It also saves us
> from implementing many gnome keyring related callbacks as you can see in the
> current code.
>
> Thank You.
> --
> Senthil Kumaran S
> http://www.stylesen.org/
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1942983
--
Thanks
Mark Phippard
http://markphip.blogspot.com/
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1944386
Received on 2009-04-27 13:30:42 CEST