Re: [PATCH] Add NNTP support to mailer.py

Jon Bendtsen <jbendtsen_at_laerdal.dk> writes:

| Hi
|
| specifying both email and nntp works fine, i get both email and nntp.
|
| Specifying the SMTP and NNTP server, but not actually using them by
| specifying a
| to_addr
| to_group
| gives errors:

Thanks a lot for testing.

| No to_group gives:
| Traceback (most recent call last):
| File "./mailer.py", line 1375, in <module>
| sys.argv[3:3+expected_args])
| File "/var/lib/python-support/python2.5/svn/core.py", line 288, in
| run_app
| return apply(func, (application_pool,) + args, kw)
| File "./mailer.py", line 105, in main
| messenger.generate()
| File "./mailer.py", line 412, in generate
| self.output.finish()
| File "./mailer.py", line 273, in finish
| server.post(self.buffer)
| File "/usr/lib/python2.5/nntplib.py", line 570, in post
| return self.getresp()
| File "/usr/lib/python2.5/nntplib.py", line 219, in getresp
| raise NNTPTemporaryError(resp)
| nntplib.NNTPTemporaryError: 441 Required "Newsgroups" header is missing
|
| No to_addr gives:
| Traceback (most recent call last):
| File "./mailer.py", line 1375, in <module>
| sys.argv[3:3+expected_args])
| File "/var/lib/python-support/python2.5/svn/core.py", line 288, in
| run_app
| return apply(func, (application_pool,) + args, kw)
| File "./mailer.py", line 105, in main
| messenger.generate()
| File "./mailer.py", line 412, in generate
| self.output.finish()
| File "./mailer.py", line 268, in finish
| server.sendmail(self.from_addr, self.to_addrs,
| self.buffer.getvalue())
| File "/usr/lib/python2.5/smtplib.py", line 703, in sendmail
| raise SMTPRecipientsRefused(senderrs)
| smtplib.SMTPRecipientsRefused: {}
|
|
|
| Imagine that you have no default values, but control everything with
| [maps]. Then it is impossible to only email, or only nntp, which
| someone might want to do.

The to_group error is mine, but the to_addr one is pre-existing I
think.

Anyways. I'll look into this and see if things can be made a bit more
robust.

-- 
	Lgb
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1861110