Re: svn commit: r37379 - trunk/subversion/tests/cmdline

2009-04-21 01:14:44 Greg Stein napisał(a):
> On Mon, Apr 20, 2009 at 20:03, Lieven Govaerts <svnlgo_at_mobsol.be> wrote:
> > On 04/20/2009 01:31 PM, Bert Huijben wrote:
> >> Author: rhuijben
> >> Date: Mon Apr 20 04:31:22 2009
> >> New Revision: 37379
> >>
> >> Log:
> >> Following up on r37368, check ra libraries instead of the url. This
> >> resolves an incompatibility with the python versions on the buildbots.
> > ..
> >> wc_dir = sbox.wc_dir
> >>
> >> - if sbox.repo_url.startswith(("http", "svn")):
> >> + if is_ra_type_svn() or is_ra_type_dav():
> >
> >
> > Bert,
> >
> > Is the problem here the url checking? Or providing a list to the
> > startswith function?
>
> The list was definitely a problem.

s/list/tuple/

> I suspect the url checking was
> slightly incorrect in that it would not allow for https:

It would allow https:, but the problem is that this syntax was introduced in Python 2.5.

http://docs.python.org/whatsnew/2.5.html#other-language-changes contains:
The startswith() and endswith() methods of string types now accept tuples of strings to check for.

-- 
Arfrever Frehtes Taifersar Arahesis