Hi Lars,
Whether *everyone* agrees or not is almost irrelevant.
It's always advisable to follow;
http://subversion.tigris.org/hacking.html#patches
when submitting any patch.
As the patch submitter - you're in the best place to do this work,
because you inherently know the intent of the patch you propose.
If you need assistance (with the code or with following the patch
submission guidelines), don't be shy to ask.
Most on the list, are almost to a fault, generous with their time for
mentoring.
Gavin.
On 15/04/2009, at 3:42 AM, Lars Gullik Bjønnes wrote:
> This is a rather dirty patch (mailer.py did not lend itself to
> modifications too nicely) that adds some more config vars to the conf
> file:
>
> For nntp handling:
>
> nntp_hostname - the nntp server to send to
> to_group - the newsgroup to send to
>
> For bug/regex handling (f.ex. for sending to bugzilla):
>
> bug_regex - the regex to match on
> bug_multi - if to send multiple messages when the regex
> matches more than once
> bug_to_addr - where to send the matching messages
> (possibly this can be dropped...)
>
>
> The matching bug_reges should have one group that matches on bug id,
> this id can be used in *_subject_prefix:
>
> commit_subject_prefix = [Bug %(bugid)s] [%(repo)s]
>
> If there are interest in cleaning this up for inclusion in subversion
> I'll update against current trunk and try to clean it up further. As
> it is now it is mostly FYI only.
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1713817
> <mailer-with-nntp-and-regex-support.diff>This is a rather dirty
> patch (mailer.py did not lend itself to
> modifications too nicely) that adds some more config vars to the conf
> file:
>
> For nntp handling:
>
> nntp_hostname - the nntp server to send to
> to_group - the newsgroup to send to
>
> For bug/regex handling (f.ex. for sending to bugzilla):
>
> bug_regex - the regex to match on
> bug_multi - if to send multiple messages when the regex
> matches more than once
> bug_to_addr - where to send the matching messages
> (possibly this can be dropped...)
>
>
> The matching bug_reges should have one group that matches on bug id,
> this id can be used in *_subject_prefix:
>
> commit_subject_prefix = [Bug %(bugid)s] [%(repo)s]
>
> If there are interest in cleaning this up for inclusion in subversion
> I'll update against current trunk and try to clean it up further. As
> it is now it is mostly FYI only.
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1713817
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1719151
Received on 2009-04-15 03:28:49 CEST