On Apr 10, 2009, at 9:14 AM, Stefan Sperling wrote:
> On Thu, Apr 09, 2009 at 01:25:26PM -0700, Hyrum K. Wright wrote:
>> Author: hwright
>> Date: Thu Apr 9 13:25:25 2009
>> New Revision: 37145
>>
>> Log:
>> Fix the build by falling back to the system svnversion if the just-
>> built one
>> fails. See this thread for more information:
>> http://svn.haxx.se/dev/archive-2009-04/0262.shtml
>>
>> * Makefile.in:
>> (revision-install): If the just-build svnversion fails, try the
>> system-installed one. If that also fails, just bail and print
>> "unknown".
>>
>> Modified:
>> trunk/Makefile.in
>
> This commit caused make to complain here:
>
> Using undefined dynamic variable $? (line 380 of Makefile)
>
> I think you wanted:
>
> Index: Makefile.in
> ===================================================================
> --- Makefile.in (revision 37157)
> +++ Makefile.in (working copy)
> @@ -370,10 +370,10 @@
> revision-install:
> subversion/svnversion/svnversion $(top_srcdir) /repos/svn/trunk > \
> $(DESTDIR)$(includedir)/subversion-1/svn-revision.txt; \
> - if test "$?" != "0"; then \
> + if test "$$?" != "0"; then \
> svnversion $(top_srcdir) /repos/svn/trunk > \
> $(DESTDIR)$(includedir)/subversion-1/svn-revision.txt; \
> - if test "$?" != "0"; then \
> + if test "$$?" != "0"; then \
> echo "unknown" > \
> $(DESTDIR)$(includedir)/subversion-1/svn-revision.txt; \
> fi; \
Yes, I believe I did. Would you mind making the change?
-Hyrum
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1631486
Received on 2009-04-10 16:24:43 CEST