[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r37145 - trunk

From: Stefan Sperling <stsp_at_elego.de>
Date: Fri, 10 Apr 2009 15:14:04 +0100

On Thu, Apr 09, 2009 at 01:25:26PM -0700, Hyrum K. Wright wrote:
> Author: hwright
> Date: Thu Apr 9 13:25:25 2009
> New Revision: 37145
>
> Log:
> Fix the build by falling back to the system svnversion if the just-built one
> fails. See this thread for more information:
> http://svn.haxx.se/dev/archive-2009-04/0262.shtml
>
> * Makefile.in:
> (revision-install): If the just-build svnversion fails, try the
> system-installed one. If that also fails, just bail and print "unknown".
>
> Modified:
> trunk/Makefile.in

This commit caused make to complain here:

    Using undefined dynamic variable $? (line 380 of Makefile)

I think you wanted:

Index: Makefile.in
===================================================================
--- Makefile.in (revision 37157)
+++ Makefile.in (working copy)
@@ -370,10 +370,10 @@
 revision-install:
         subversion/svnversion/svnversion $(top_srcdir) /repos/svn/trunk > \
             $(DESTDIR)$(includedir)/subversion-1/svn-revision.txt; \
- if test "$?" != "0"; then \
+ if test "$$?" != "0"; then \
           svnversion $(top_srcdir) /repos/svn/trunk > \
             $(DESTDIR)$(includedir)/subversion-1/svn-revision.txt; \
- if test "$?" != "0"; then \
+ if test "$$?" != "0"; then \
             echo "unknown" > \
               $(DESTDIR)$(includedir)/subversion-1/svn-revision.txt; \
           fi; \

Stefan
Received on 2009-04-10 16:14:30 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.