Re: [PATCH] (2nd attempt) Completed TODO: svn_stream_copy3()

Martin Furter wrote:
> On Wed, 8 Apr 2009, Edmund Wong wrote:
>
> Often the variable is just named 'err', or 'err2'.
>
> The following looks very complicated. Why not just something like this:
>
> err = somefunc();
> if (err)
> break;
>
> As soon as there is an error you can leave the loop as has been done until
> now.

I'll redo the patch and repost it.

Thanks for the review. Very much appreciated.

Edmund

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1612661
Received on 2009-04-09 12:45:29 CEST