Re: svn commit: r37073 - trunk/tools/client-side

Greg Stein wrote:
> On Tue, Apr 7, 2009 at 18:19, C. Michael Pilato <cmpilato_at_collab.net> wrote:
>> Author: cmpilato
>> Date: Tue Apr 7 09:19:05 2009
>> New Revision: 37073
>>
>> Log:
>> Add a new tool I've been tinkering with as a prototype of some
>> viewspec functionality for Subversion. It has plenty of room for
>> improvement, but seems to have basic working functionality.
>
> Why the tree? You sort the paths into a list such that all parents
> will come first. You should be able to process them just like that,
> rather than jamming them into some weird ol' tree structure.

It's just the way I was thinking about the problem at the time, I guess. I
wanted to know up-front which intermediate paths would be needed (that
weren't explicitly named in the specfile), for example, and didn't want to
process those more than once. For a reason I can't recall now I was
thinking it would help me do exclusion a little more easily. *shrug*

> Also, the "getters" are not worth it in Python. Just declare the
> attributes public and fetch them. As Guido says, "we're all adults
> here". No need to hide them or think users will monkey with them.

Okay. Wasn't sure what the prescribed approach was on this one.

> I made a few little (untested) edits to clean it up a bit.

Saw 'em. Good change.

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1580974