Re: svn commit: r37073 - trunk/tools/client-side

On Tue, Apr 7, 2009 at 18:19, C. Michael Pilato <cmpilato_at_collab.net> wrote:
> Author: cmpilato
> Date: Tue Apr  7 09:19:05 2009
> New Revision: 37073
>
> Log:
> Add a new tool I've been tinkering with as a prototype of some
> viewspec functionality for Subversion.  It has plenty of room for
> improvement, but seems to have basic working functionality.

Why the tree? You sort the paths into a list such that all parents
will come first. You should be able to process them just like that,
rather than jamming them into some weird ol' tree structure.

Also, the "getters" are not worth it in Python. Just declare the
attributes public and fetch them. As Guido says, "we're all adults
here". No need to hide them or think users will monkey with them.

>...

I made a few little (untested) edits to clean it up a bit.

Cheers,
-g

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1580570
Received on 2009-04-07 19:50:53 CEST