Re: [PATCH] Modified message in libsvn_client/delete.c

Stefan Sperling wrote:
> On Fri, Apr 03, 2009 at 11:37:04PM +0800, Edmund Wong wrote:
>> Stefan Sperling wrote:
>>> Yes it would, good point.
>>>
>>> So what about the diff below? Running 'make check' on it now.
>>>
>>> Index: subversion/libsvn_client/delete.c
>>> ===================================================================
>>> --- subversion/libsvn_client/delete.c (revision 36961)
>>> +++ subversion/libsvn_client/delete.c (working copy)
>>> @@ -64,7 +64,8 @@ find_undeletables(void *baton,
>>> (status->prop_status != svn_wc_status_none
>>> && status->prop_status != svn_wc_status_normal))
>>> return svn_error_createf(SVN_ERR_CLIENT_MODIFIED, NULL,
>>> - _("'%s' has local modifications"),
>>> + _("'%s' has local modifications, commit or revert "
>>> + "them first"),
>>> svn_path_local_style(path, pool));
>>>
>>> return SVN_NO_ERROR;
>>>
>> This is nice and concise. I probably would've been less concise.
>> *grin*
>
> Great. r36971.

Eek. Please fix the bogus punctuation:

   '%s' has local modifications -- commit or revert them first

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1562847