2009/4/6 Arfrever Frehtes Taifersar Arahesis <arfrever.fta_at_gmail.com>:
> 2009-04-06 01:03:02 Greg Stein napisał(a):
>...
>> >> You're making the tests less useful by hiding potential errors.
>> >
>> > What potential errors?
>>
>> Regressions in our code base. Potential/future errors.
>>
>> The point is, that you're breaking our test suite's ability to locate
>> future problems in our codebase. Rewriting the output loses
>> information that may be important to detecting bugs.
>
> I disagree, but what do you think about?:
>
> for dirpath, dirs, files in os.walk(base):
> parent = path_to_key(dirpath, base)
> if ignore_svn and dot_svn in dirs:
> dirs.remove(dot_svn)
> for name in dirs + files:
> node = os.path.join(dirpath, name)
> if os.path.isfile(node):
> try:
> contents = open(node, 'r').read()
> except UnicodeDecodeError:
> contents = open(node, 'rb').read()
> if sys.platform == 'win32':
> contents = contents.replace('\r\n', '\n')
> else:
> contents = None
> desc[repos_join(parent, name)] = StateItem(contents=contents)
Yeah... I just saw that recently. That is also broken. It means we
cannot detect whether file contents have the correct style of newline
in them.
-g
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1561498
Received on 2009-04-06 15:05:00 CEST