Re: svn commit: r37008 - trunk/subversion/tests/cmdline/svntest

2009-04-05 23:06:14 Branko Čibej napisał(a):
> Arfrever Frehtes Taifersar Arahesis wrote:
> > I have found a computer with Windows system, I installed Python on that system
> > and I tested opening some test files with different line endings.
> > When opening a file [1] with either "\r\n" or "\n" or mixed line endings in text mode,
> > and reading it, all line endings were automatically transformed into "\n". There
> > were no errors. When opening in binary mode [2], actual line endings were used.
> > Replacing of line endings [3] was working correctly.
> >
> > [1] open(file, "r").read()
> > [2] open(file, "rb").read()
> > [3] open(file, "rb").read().replace("\r\n", "\n")
> >
>
> Sorry, how is that relevant? Anyone who knows anything about how
> text-mode files work already knows this.

Bert Huijben claimed that opening a file with "\n" line endings on Windows
would cause some errors (maybe exceptions throwed by 'raise' from Python internal
modules).

> You're making the tests less useful by hiding potential errors.

What potential errors?

-- 
Arfrever Frehtes Taifersar Arahesis