[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r37008 - trunk/subversion/tests/cmdline/svntest

From: Branko Cibej <brane_at_xbc.nu>
Date: Sun, 05 Apr 2009 23:06:14 +0200

Arfrever Frehtes Taifersar Arahesis wrote:
> I have found a computer with Windows system, I installed Python on that system
> and I tested opening some test files with different line endings.
> When opening a file [1] with either "\r\n" or "\n" or mixed line endings in text mode,
> and reading it, all line endings were automatically transformed into "\n". There
> were no errors. When opening in binary mode [2], actual line endings were used.
> Replacing of line endings [3] was working correctly.
>
> [1] open(file, "r").read()
> [2] open(file, "rb").read()
> [3] open(file, "rb").read().replace("\r\n", "\n")
>

Sorry, how is that relevant? Anyone who knows anything about how
text-mode files work already knows this. You're missing the point.
You're making the tests less useful by hiding potential errors. Don't do
that.

-- Brane

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1554575
Received on 2009-04-05 23:06:31 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.