Glanced over the mail. I'll be online in ~ an hour and will look at
the issue then.
(Oh, and I've got an idea of why revert 17 is failing, too. You're
going to love this one...)
-Hyrum
On Apr 1, 2009, at 7:41 AM, Greg Stein wrote:
> Hyrum,
>
> I tracked down the problem with diff_tests 4. Ugh.
>
> At a high level, "svn diff" is not reporting the change in A/D/G/rho.
> The diff simply returns. Yet it is *clearly* different.
>
> Also: it happens sporadically.
>
> Works for wc-1, fails for wc-ng.
>
> The problem originates in svn_wc__text_modified_interal_p() in
> wc/questions.c. During the diff process, this is called with
> force_comparison==FALSE, so the entry values are examined to shortcut
> the process. Under wc-ng, working_size == -1 so a size comparison is
> not performed. And *sometimes* mtime == text_time (no modification!)
> and other times mtime == (text_time + 1 second) which means "yup.
> modified."
>
> IOW, depending on what gets recorded for text_time, we may or may not
> flag a difference. It *never* reaches the byte-for-bye comparison.
>
> Under wc-1, the working_size is always valid, and the different file
> sizes are properly detected. TODO: eliminate the size check and see if
> wc-1 has a similar time race.
>
>
> For wc-ng, there are two things to do:
>
> 1) get working_size to have a correct value (for entries
> compatibility)
> 2) track down the variance in text_time recording
>
> I'm going to work on the wc-1 TODO, and part 2. If you could track why
> working_size comes out as -1 in wc-ng, then we could nail this.
>
> Cheers,
> -g
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1506728
Received on 2009-04-01 14:51:47 CEST