[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: build for 1.5.6 fails on solaris-10: java-hl

From: Branko Cibej <brane_at_xbc.nu>
Date: Mon, 23 Mar 2009 22:36:56 +0100

thurner rupert wrote:
> hi,
>
> allow me to forward a message from the opencsw maintainers list,
> dieter dirkes, on how he solved this:
>
>
> In /subversion/bindings/javahl/native/Pool.h you find this:
> APR_INLINE
> apr_pool_t *Pool::pool () const
> {
> return m_pool;
> }
>
> APR_INLINE
> void Pool::clear() const
> {
> svn_pool_clear(m_pool);
> }
>
>
> This leads the SUN compiler to include the 2 methods in all files (=>
> multiply defined).
>

This is C++ code, so clearly APR_INLINE (which is defined based on C,
not C++, compiler features) must not be used.

I would also suggest you use "static inline" instead of "inline" because
the C++ standard defines a subtly (or horribly, depending on your point
of view) different meaning to the two. "static inline" is what you want
99% of the time, and 100% of the time if you can't tell the difference. :)

-- Brane

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1393095
Received on 2009-03-23 22:37:15 CET

This is an archived mail posted to the Subversion Dev mailing list.