[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: r33873 and r33874

From: Arfrever Frehtes Taifersar Arahesis <Arfrever.FTA_at_GMail.Com>
Date: Sun, 15 Mar 2009 12:32:05 +0100

2009-03-14 05:06:41 Edmund Wong napisaƂ(a):
> Hi,
> I'm a 'newbie' helping out with the revision merging for 1.5.x, and
> came across r34420, which is:
> Merge r33873, r33874 from trunk:
> * r33873, r33874
> Old API-accessible bug where a certain combination of revision
> arguments to svn_repos_get_logs returns garbage. Has tests.
> Votes:
> +1: glasser, cmpilato, rhuijben
> I noticed that in the Changes-Till-1.5.5 that r33873 was mentioned:
> * fixed: svn_repos_get_logs() chokes on some revision arguments (r33873, -4)


It means r33873 and r33874.

> but r33874 wasn't.
> Looking up ViewVC, I noticed r33874 describes the above fix rather
> than r33873, since r33873 is :
> Add a regression test for a broken API.
> * subversion/tests/libsvn_repos/repos-test.c
> (log_receiver): New function.
> (get_logs): New test just for quickly verifying the sanity of
> various revision ranges and limit values thrown at
> svn_repos_get_logs4. Current expected to fail.
> (test_funcs): Add reference to new test.
> Of course, being new to this, I might have misinterpreted both
> revisions. (Emphasis should be placed on the 'new'. I do use
> SVN, but only the basic check in, check out and update. No
> branching and revisions, so some terminology flies right by
> me.)
> (Side note: Perhaps I should have familiarized myself with
> the terminology before volunteering for this, but I suppose
> it's a good place to help out given that I know C as much
> as I know the road map of Katmandu. IOW, utter useless.)

Arfrever Frehtes Taifersar Arahesis

Received on 2009-03-15 12:33:14 CET

This is an archived mail posted to the Subversion Dev mailing list.