r33873 and r33874

Hi,

I'm a 'newbie' helping out with the revision merging for 1.5.x, and
came across r34420, which is:

Merge r33873, r33874 from trunk:

* r33873, r33874
   Old API-accessible bug where a certain combination of revision
   arguments to svn_repos_get_logs returns garbage. Has tests.
   Votes:
     +1: glasser, cmpilato, rhuijben

I noticed that in the Changes-Till-1.5.5 that r33873 was mentioned:

  * fixed: svn_repos_get_logs() chokes on some revision arguments (r33873, -4)

but r33874 wasn't.

Looking up ViewVC, I noticed r33874 describes the above fix rather
than r33873, since r33873 is :

  Add a regression test for a broken API.

  * subversion/tests/libsvn_repos/repos-test.c
    (log_receiver): New function.
    (get_logs): New test just for quickly verifying the sanity of
      various revision ranges and limit values thrown at
      svn_repos_get_logs4. Current expected to fail.
    (test_funcs): Add reference to new test.

Of course, being new to this, I might have misinterpreted both
revisions. (Emphasis should be placed on the 'new'. I do use
SVN, but only the basic check in, check out and update. No
branching and revisions, so some terminology flies right by
me.)

(Side note: Perhaps I should have familiarized myself with
the terminology before volunteering for this, but I suppose
it's a good place to help out given that I know C as much
as I know the road map of Katmandu. IOW, utter useless.)

Thanks for the clarification,

Edmund

--
"Pax tecum"
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1320206