Bert Huijben wrote:
>> -----Original Message-----
>> From: Arfrever Frehtes Taifersar Arahesis [mailto:arfrever.fta_at_gmail.com]
>> Sent: dinsdag 10 maart 2009 13:25
>> To: Bert Huijben; Subversion Development
>> Subject: Re: svn commit: r36439 - trunk/subversion/tests/cmdline
>>
>> 2009-03-09 22:20 Bert Huijben <rhuijben_at_sharpsvn.net> napisał(a):
>>
>>> Author: rhuijben
>>> Date: Mon Mar 9 14:20:25 2009
>>> New Revision: 36439
>>>
>>> Log:
>>> * subversion/tests/cmdline/diff_tests.py
>>> (test_list): Mark diff_svnpatch as skipped until the test is fixed.
>>> * subversion/tests/cmdline/patch_tests.py
>>> (test_list): Mark all tests as skipped until the tests are fixed.
>>>
>>> Modified:
>>> trunk/subversion/tests/cmdline/diff_tests.py
>>> trunk/subversion/tests/cmdline/patch_tests.py
>>>
>>> Modified: trunk/subversion/tests/cmdline/diff_tests.py
>>> URL:
>>>
>> http://svn.collab.net/viewvc/svn/trunk/subversion/tests/cmdline/diff_tests.py?
>> pathrev=36439&r1=36438&r2=36439
>>
>> ==============================================================================
>>
>>> --- trunk/subversion/tests/cmdline/diff_tests.py Mon Mar 9 14:06:31
>>>
>> 2009 (r36438)
>>
>>> +++ trunk/subversion/tests/cmdline/diff_tests.py Mon Mar 9 14:20:25
>>>
>> 2009 (r36439)
>>
>>> @@ -3483,7 +3483,7 @@ test_list = [ None,
>>> diff_external_diffcmd,
>>> XFail(diff_url_against_local_mods),
>>> XFail(diff_preexisting_rev_against_local_add),
>>> - diff_svnpatch,
>>> + Skip(diff_svnpatch),
>>>
>> Temporary XFail would be better than Skip.
>>
>
> I suggested marking them Xfail, but gstein warned against it, as on some linux environments it works and on some it doesn't.
>
> Marking it as XFail will give XPass errors on buildbots where it passed before.
>
Isn't the whole point of the test suite to identify bugs? So, if you
unconditionally Skip a test that fails on some platforms, it'll never
get fixed because it'll never get run, and no-one ever reviews skipped
tetss. Might as well remove the test then, what's the point?
Or maybe fix the bug, who knows.
-- Brane
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1303028
Received on 2009-03-10 14:42:44 CET