[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r36439 - trunk/subversion/tests/cmdline

From: Bert Huijben <rhuijben_at_sharpsvn.net>
Date: Tue, 10 Mar 2009 14:30:18 +0100

> -----Original Message-----
> From: Arfrever Frehtes Taifersar Arahesis [mailto:arfrever.fta_at_gmail.com]
> Sent: dinsdag 10 maart 2009 13:25
> To: Bert Huijben; Subversion Development
> Subject: Re: svn commit: r36439 - trunk/subversion/tests/cmdline
>
> 2009-03-09 22:20 Bert Huijben <rhuijben_at_sharpsvn.net> napisaƂ(a):
> > Author: rhuijben
> > Date: Mon Mar 9 14:20:25 2009
> > New Revision: 36439
> >
> > Log:
> > * subversion/tests/cmdline/diff_tests.py
> > (test_list): Mark diff_svnpatch as skipped until the test is fixed.
> > * subversion/tests/cmdline/patch_tests.py
> > (test_list): Mark all tests as skipped until the tests are fixed.
> >
> > Modified:
> > trunk/subversion/tests/cmdline/diff_tests.py
> > trunk/subversion/tests/cmdline/patch_tests.py
> >
> > Modified: trunk/subversion/tests/cmdline/diff_tests.py
> > URL:
> http://svn.collab.net/viewvc/svn/trunk/subversion/tests/cmdline/diff_tests.py?
> pathrev=36439&r1=36438&r2=36439
> >
> ==============================================================================
> > --- trunk/subversion/tests/cmdline/diff_tests.py Mon Mar 9 14:06:31
> 2009 (r36438)
> > +++ trunk/subversion/tests/cmdline/diff_tests.py Mon Mar 9 14:20:25
> 2009 (r36439)
> > @@ -3483,7 +3483,7 @@ test_list = [ None,
> > diff_external_diffcmd,
> > XFail(diff_url_against_local_mods),
> > XFail(diff_preexisting_rev_against_local_add),
> > - diff_svnpatch,
> > + Skip(diff_svnpatch),
>
> Temporary XFail would be better than Skip.

I suggested marking them Xfail, but gstein warned against it, as on some linux environments it works and on some it doesn't.

Marking it as XFail will give XPass errors on buildbots where it passed before.

        Bert

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1303001
Received on 2009-03-10 14:30:41 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.