[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r36078 - in trunk/subversion: include/private libsvn_subr

From: Ivan Zhakov <ivan_at_visualsvn.com>
Date: Tue, 24 Feb 2009 01:03:00 +0300

On Mon, Feb 23, 2009 at 7:34 PM, Greg Stein <gstein_at_gmail.com> wrote:
> Author: gstein
> Date: Mon Feb 23 08:34:29 2009
> New Revision: 36078
> Log:
> Add new binding/retrieval functions to our sqlite interface to deal with
> svn datatypes.
>+svn_error_t *
>+svn_sqlite__column_properties(apr_hash_t **props,
>+ svn_sqlite__stmt_t *stmt,
>+ int column,
>+ apr_pool_t *result_pool,
>+ apr_pool_t *scratch_pool)

Not related to this commit, but from my experience it's a good
practice add boolean parameter to such database accessors to raise
error on NULL value.

svn_sqlite__column_properties(apr_hash_t **props,
                              svn_sqlite__stmt_t *stmt,
                              int column,
                              svn_boolean_t allow_null,
                              apr_pool_t *result_pool,
                              apr_pool_t *scratch_pool)

I know that NOT NULL are enforcement by sqlite schema, but it's better
to prevent dereference null pointer in our code. Sometimes schema
changes while some of accessors does not updated.

Ivan Zhakov
VisualSVN Team
Received on 2009-02-23 23:03:19 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.