[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r35810 - trunk/subversion/libsvn_subr

From: Senthil Kumaran S <senthil_at_collab.net>
Date: Thu, 12 Feb 2009 15:40:41 +0530

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hyrum K. Wright wrote:
> On Feb 11, 2009, at 9:52 AM, Hyrum K. Wright wrote:
>
>> Author: hwright
>> Date: Wed Feb 11 07:52:20 2009
>> New Revision: 35810
>>
>> Log:
>> More efficiently cleanup existing prepared statements when closing
>> an SQLite
>> database.
>>
>> * subversion/libsvn_subr/sqlite.c
>> (close_apr): Use the sqlite3_next_stmt() API to fetch any outstanding
>> prepared statements, and cleanup error handling.
>>
>> Modified:
>> trunk/subversion/libsvn_subr/sqlite.c
>
> ...
>
> This change added use of sqlite3_next_stmt(), which was introduced in
> SQLite 3.6.0. We currently state the the minimum required version of
> SQLite is 3.4.0, but that was before we added support for building the
> SQLite amalgamation as part of Subversion. I currently see two options:
> * Bump the minimum required version

Though SQLite 3.6.0 was released in 2008 July 16, most of the distros are still
with 3.5.9 or even older versions. So I think bumping the minimum required
version (which is 3.4.0 right now) will not be the best solution.

> * Roll back r35810.

I think we can do this and keep it for future.

Thank You.
- --
Senthil Kumaran S
http://www.stylesen.org/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkmT9aAACgkQ9o1G+2zNQDiO7wCgxDKYV/zIa76LWlbw73RQnhs+
3yUAoJhsrmquo3auvCj2GmgZHJcvwRst
=ufAd
-----END PGP SIGNATURE-----

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1144200
Received on 2009-02-12 20:55:56 CET

This is an archived mail posted to the Subversion Dev mailing list.