[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r35810 - trunk/subversion/libsvn_subr

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: Wed, 11 Feb 2009 10:42:39 -0600

On Feb 11, 2009, at 9:52 AM, Hyrum K. Wright wrote:

> Author: hwright
> Date: Wed Feb 11 07:52:20 2009
> New Revision: 35810
> Log:
> More efficiently cleanup existing prepared statements when closing
> an SQLite
> database.
> * subversion/libsvn_subr/sqlite.c
> (close_apr): Use the sqlite3_next_stmt() API to fetch any outstanding
> prepared statements, and cleanup error handling.
> Modified:
> trunk/subversion/libsvn_subr/sqlite.c


This change added use of sqlite3_next_stmt(), which was introduced in
SQLite 3.6.0. We currently state the the minimum required version of
SQLite is 3.4.0, but that was before we added support for building the
SQLite amalgamation as part of Subversion. I currently see two options:
  * Bump the minimum required version
  * Roll back r35810.
  * (Well, a third option is to maintain two separate #ifdef'd
implementations, but I don't think we want to go down that road.)



Received on 2009-02-11 17:43:00 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.