[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Segfault in ruby tests

From: Kouhei Sutou <kou_at_cozmixng.org>
Date: Tue, 10 Feb 2009 00:26:10 +0900 (JST)

Hi,

In <49903D9C.8020609_at_collab.net>
  "Re: Segfault in ruby tests" on Mon, 09 Feb 2009 09:28:44 -0500,
  "C. Michael Pilato" <cmpilato_at_collab.net> wrote:

> wouldn't expect this to actually remedy a pool lifetime problem. So, if we
> can't explain exactly why your patch helps and what problem it solves, my
> vote is -1 on applying it. We don't want to make the tests stop failing; we
> want to make Subversion work correctly (and we'll happily accept passing
> tests as a benefit of that change).

I think that "someone says the fix is not correct" or "you
say the tests are wrong" is needed before you vote -1.

I'm sorry but I don't have time to look into the problem
now. There are a code that reproduces the problem and a
patch that fixes (or hides) the problem. It seems that
someone can look into the problem.

(My expectation WITHOUT foundation: I think that
svn_txdelta_send_stream() destroys passed pool
somewhere. The passed pool is not top-level pool
(svn_pool_create(parent_pool)) normally but it may be
top-level pool (svn_pool_create(NULL)) in the Ruby bindings
test. The difference may cause the problem.)

Thanks,

--
kou
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1129450
Received on 2009-02-09 16:26:55 CET

This is an archived mail posted to the Subversion Dev mailing list.