[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r35446 - trunk/subversion/libsvn_diff

From: Lieven Govaerts <svnlgo_at_mobsol.be>
Date: Sun, 25 Jan 2009 13:46:47 +0100

Arfrever Frehtes Taifersar Arahesis wrote:
..
>
> Modified: trunk/subversion/libsvn_diff/diff_file.c
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_diff/diff_file.c?pathrev=35446&r1=35445&r2=35446
> ==============================================================================
> --- trunk/subversion/libsvn_diff/diff_file.c Sat Jan 24 10:48:15 2009 (r35445)
> +++ trunk/subversion/libsvn_diff/diff_file.c Sat Jan 24 17:55:07 2009 (r35446)
> @@ -37,6 +37,7 @@
> #include "svn_private_config.h"
> #include "svn_path.h"
> #include "svn_ctype.h"
> +#include "../libsvn_subr/utf_impl.h"
>
> /* A token, i.e. a line read from a file. */
> typedef struct svn_diff__file_token_t
> @@ -1074,6 +1075,14 @@ output_unified_diff_modified(void *baton
> {
> output_baton->hunk_extra_context[--p] = '\0';
> }
> + const char *invalid_character =
> + svn_utf__last_valid(output_baton->hunk_extra_context,
> + SVN_DIFF__EXTRA_CONTEXT_LENGTH - 1);

This breaks the Windows buildbot (DLL build):
http://www.mobsol.be/buildbot/builders/win32-xp%20VS2005/builds/1695/steps/Build/logs/stdio

If I remember correctly, utf_impl.h should be added to the msvc-export
attribute of libsvn_subr in build.conf. Oh, and moved to
subversion/include/private.

Lieven

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1049689
Received on 2009-01-25 13:47:04 CET

This is an archived mail posted to the Subversion Dev mailing list.