[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r35446 - trunk/subversion/libsvn_diff

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Sun, 25 Jan 2009 08:23:35 +0200 (Jerusalem Standard Time)

> @@ -1074,6 +1075,14 @@ output_unified_diff_modified(void *baton
> {
> output_baton->hunk_extra_context[--p] = '\0';
> }
> + const char *invalid_character =
> + svn_utf__last_valid(output_baton->hunk_extra_context,
> + SVN_DIFF__EXTRA_CONTEXT_LENGTH - 1);

s/SVN_DIFF__EXTRA_CONTEXT_LENGTH - 1/SVN_DIFF__EXTRA_CONTEXT_LENGTH + 1/ ?

Notice that it's declared as:

  char hunk_extra_context[SVN_DIFF__EXTRA_CONTEXT_LENGTH + 1];

and svn_utf__last_valid() does

    consr char *p = data;
    while (p++ < data + len)
      ...

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1048786
Received on 2009-01-25 13:37:52 CET

This is an archived mail posted to the Subversion Dev mailing list.