[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r35435 - in trunk/subversion: include/private libsvn_subr

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: Sat, 24 Jan 2009 20:19:54 -0600

Bert Huijben wrote:
>> -----Original Message-----
>> From: Hyrum K. Wright [mailto:hyrum_at_hyrumwright.org]
>> Sent: Friday, January 23, 2009 9:39 PM
>> To: svn_at_subversion.tigris.org
>> Subject: svn commit: r35435 - in trunk/subversion: include/private
>> libsvn_subr
>>
>> Author: hwright
>> Date: Fri Jan 23 12:39:08 2009
>> New Revision: 35435
>>
>> Log:
>> Update sqlite vararg binding to bind blobs.
>>
>> * subversion/libsvn_subr/sqlite.c
>> (vbindf): Use 'b' for blob values.
>>
>> * subversion/include/private/svn_sqlite.h
>> (svn_sqlite__bindf): Update docs.
>>
>> Modified:
>> trunk/subversion/include/private/svn_sqlite.h
>> trunk/subversion/libsvn_subr/sqlite.c
>>
>> Modified: trunk/subversion/include/private/svn_sqlite.h
>> URL:
>> http://svn.collab.net/viewvc/svn/trunk/subversion/include/private/svn_s
>> qlite.h?pathrev=35435&r1=35434&r2=35435
>> =======================================================================
>> =======
>> --- trunk/subversion/include/private/svn_sqlite.h Fri Jan 23
>> 12:34:18 2009 (r35434)
>> +++ trunk/subversion/include/private/svn_sqlite.h Fri Jan 23
>> 12:39:08 2009 (r35435)
>> @@ -102,6 +102,8 @@ svn_sqlite__prepare(svn_sqlite__stmt_t *
>> ---- ----------------- ---------
>> i apr_int64_t Number
>> s const char ** String
>> + b const void * Blob (must be followed by an additional
>> argument
>> + with the number of bytes in the
>> object)
>
> I think you should also document the type of the length value as apr_size_t
> here.

Agreed. r35447.

-Hyrum

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1048043
Received on 2009-01-25 03:21:17 CET

This is an archived mail posted to the Subversion Dev mailing list.