[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r35435 - in trunk/subversion: include/private libsvn_subr

From: Bert Huijben <rhuijben_at_sharpsvn.net>
Date: Sat, 24 Jan 2009 00:13:07 +0100

> -----Original Message-----
> From: Hyrum K. Wright [mailto:hyrum_at_hyrumwright.org]
> Sent: Friday, January 23, 2009 9:39 PM
> To: svn_at_subversion.tigris.org
> Subject: svn commit: r35435 - in trunk/subversion: include/private
> libsvn_subr
>
> Author: hwright
> Date: Fri Jan 23 12:39:08 2009
> New Revision: 35435
>
> Log:
> Update sqlite vararg binding to bind blobs.
>
> * subversion/libsvn_subr/sqlite.c
> (vbindf): Use 'b' for blob values.
>
> * subversion/include/private/svn_sqlite.h
> (svn_sqlite__bindf): Update docs.
>
> Modified:
> trunk/subversion/include/private/svn_sqlite.h
> trunk/subversion/libsvn_subr/sqlite.c
>
> Modified: trunk/subversion/include/private/svn_sqlite.h
> URL:
> http://svn.collab.net/viewvc/svn/trunk/subversion/include/private/svn_s
> qlite.h?pathrev=35435&r1=35434&r2=35435
> =======================================================================
> =======
> --- trunk/subversion/include/private/svn_sqlite.h Fri Jan 23
> 12:34:18 2009 (r35434)
> +++ trunk/subversion/include/private/svn_sqlite.h Fri Jan 23
> 12:39:08 2009 (r35435)
> @@ -102,6 +102,8 @@ svn_sqlite__prepare(svn_sqlite__stmt_t *
> ---- ----------------- ---------
> i apr_int64_t Number
> s const char ** String
> + b const void * Blob (must be followed by an additional
> argument
> + with the number of bytes in the
> object)

I think you should also document the type of the length value as apr_size_t
here.

        Bert

>
> Each character in FMT maps to one argument, in the order they
> appear.
> */
>
> Modified: trunk/subversion/libsvn_subr/sqlite.c
> URL:
> http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_subr/sqlite.c?
> pathrev=35435&r1=35434&r2=35435
> =======================================================================
> =======
> --- trunk/subversion/libsvn_subr/sqlite.c Fri Jan 23 12:34:18 2009
> (r35434)
> +++ trunk/subversion/libsvn_subr/sqlite.c Fri Jan 23 12:39:08 2009
> (r35435)
> @@ -229,6 +229,12 @@ vbindf(svn_sqlite__stmt_t *stmt, const c
> va_arg(ap, apr_int64_t)));
> break;
>
> + case 'b':
> + SVN_ERR(svn_sqlite__bind_blob(stmt, count,
> + va_arg(ap, const void *),
> + va_arg(ap, apr_size_t)));
> + break;
> +
> default:
> SVN_ERR_MALFUNCTION();
> }
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=495&dsMessageI
> d=1045354

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1045612
Received on 2009-01-24 00:13:31 CET

This is an archived mail posted to the Subversion Dev mailing list.